ConvertUTF.{cpp,h} are non-free #12

cstrahan · 2018-04-10T17:43:42Z

The ConvertUTF.{cpp,h} are non-free (and buggy/unmaintained), as discussed on the Debian mailing list:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823100

This poses problems for packaging/redistribution. Would it be possible to, perhaps, support linking with libicu for this purpose?

We're currently using linenoise-ng in Nix, and this is same issue is blocking an effort to package Nix for Debian. replxx looks nice, and if we could get this issue resolved here, it's possible we'd switch away from linenoise-ng.

Thanks!

The text was updated successfully, but these errors were encountered:

AmokHuginnsson · 2018-04-10T23:42:29Z

I am quite open to use alternative to ConvertUTF.{cpp,h}, it can be ICU or some other conversion library, as long as the choice of the conversion library is preserved for users (and preferable handled by cmake).
What I mean is that I would like for the users to still use ConvertUTF.{cpp,h} if they prefer to. That would mean abstracting out conversion interface.
I will happily accept pull request implementing this change having all conversion backends working, I mean both ICU and ConvertUTF.{cpp,h}.
Debian people could simply ignore ConvertUTF.{cpp,h} files and use ICU for their build.
I still want to have ConvertUTF.{cpp,h} available for MSVCXX users sake as bringing ICU as hard dependency could significantly increase MSVCXX build difficulty.

dothebart · 2018-04-11T08:36:47Z

We @arangodb have similar opinions on that. If you propose a patch to replace this by ICU (which is already one of the other arangodb dependencies) we could drop ConvertUTF.{CPP,}. However, we currently don't have the time to work on this.

doug-moen · 2018-07-06T15:40:42Z

If Debian is correct, and this code isn't open source, then I'll need to fix the problem before I can use replxx in my open source project. However, I notice that LLVM contains the same source file, and Debian contains an LLVM package.

I used apt-get source llvm-6.0-dev to get the latest version of the Debian source package for LLVM. The file lib/Support/ConvertUTF.cpp in LLVM is recognizably the same code, with the same original licence text. One difference is that the LLVM version of ConvertUTF.cpp has the LLVM licence pasted at the top of the file, before the Unicode licence.

So maybe this isn't actually a problem. Or maybe Debian can be made happy by copying the LLVM version of ConvertUTF.cpp, even though it's really the same code with the same licence. I doubt that there is any actual legal risk of "Unicode, Inc" suing users of replxx for licence violation. Why wouldn't they go after bigger targets like LLVM or Apple first?

AmokHuginnsson · 2018-07-07T10:18:21Z

@doug-moen
Hello, thank you for taking interest in replxx.

I am not a lawyer. I could use llvm's version of ConvertUTF.{cpp,h} if some Debian maintainer confirmed that is would be sufficient. Using libicu is another option.

Unfortunatelly right now I do not have the time to take care of it.
Fixing how special keys are handled (#6) is higher on my TODO list anyway.

doug-moen · 2018-07-07T10:34:49Z

Okay, thanks. I was trying to figure out if there is actually an issue that needs to be fixed. I'd volunteer to fix it myself if there was an actual problem. However, I wouldn't consider LLVM non-free or refuse to link to it due to its use of ConvertUTF, and for consistency I should treat replxx the same way.

So I decided there's no issue, and I'm now using replxx in my project, replacing GNU readline. Thanks for making the project.

olegator77 · 2018-07-27T05:24:00Z

Hi!
I can suggest switch to utf8cpp library - It has native C++ API, and free license.

BTW, i had replaced ConvertUTF by utf8cpp in my projects. It works fine :)

LoganDark · 2018-09-27T06:34:44Z

@olegator77 what about normal C?

olegator77 · 2018-09-27T10:37:31Z

@LoganDark replxx is C++ library, so actually it seems - normal: add C++ library instead of plain C library

LoganDark · 2018-09-27T10:39:10Z

Okay, I guess C++ and C are completely interoperable then.

sbadia · 2020-04-02T21:47:45Z

Hi here,

As said @olegator77, utf8cpp library seems a good candidate.
taglib project has encounter the same issue with ConvertUTF.{ccp,h} (see taglib/taglib#793) and has migrated to utf8cpp lib (see this pull-request: taglib/taglib#794)

Cherry-pick SIGWINCH handling

minfrin · 2021-11-17T11:53:05Z

Confirmation that this issue blocks inclusion to Fedora:

https://bugzilla.redhat.com/show_bug.cgi?id=2017179#c8

minfrin · 2021-11-17T12:14:21Z

Suggestion to use code used by LLVM project, which has acceptable license:

#125 (comment)

minfrin · 2021-11-22T08:56:16Z

From https://bugzilla.redhat.com/show_bug.cgi?id=2017179#c9

--- Comment #9 from Zbigniew Jędrzejewski-Szmek [email protected] ---
%{_libdir}/.so.

Please specify the SO VERSION here, don't use a glob. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

I don't think Unicode Strict can be accepted into Fedora, though. So we will have to wait on that issue. I have subscribed as well.

After looking at the original file, the license is problematic. The proposed
solution
of using the file in LLVM does not be a solution: I think LLVM is in
"violation" of the literal
license terms too, and they should not say that this file is available under
the Apache2 license.
I used quotes because it seems that the actual legal risk is negligible.
Nevertheless, we want to
keep everything kosher in Fedora, so we don't want to accept this minor
violation.

utf8cpp seems like a better approach. [1] does a similar conversion, and it
seems very
straightforward. utf8cpp is in Fedora, so we'd want to just use the system
library.

Note that this license was briefly discussed on legal@, but the question was
sidestepped because
the files weren't actually used [2].

[1] https://github.com/taglib/taglib/pull/794/files
[2]
https://lists.fedoraproject.org/archives/list/[email protected]/thread/KQEAGD4UCDRO2X5P4WYOOT5FUFWXJ4NP/#KQEAGD4UCDRO2X5P4WYOOT5FUFWXJ4NP

You may get uncaugh exception (in case of i.e. broken pipe): terminating with uncaught exception of type std::runtime_error: write failed On destroy: (lldb) target create "clickhouse-22.8-release" --core "core.clickhouse-clie.402986-642410" bt Core file '/wrk/core.clickhouse-clie.402986-642410' (x86_64) was loaded. (lldb) bt * thread AmokHuginnsson#1, name = 'clickhouse-clie', stop reason = signal SIGABRT * frame #0: 0x00007f03fb5c900b libc.so.6`raise + 203 frame AmokHuginnsson#1: 0x00007f03fb5a8859 libc.so.6`abort + 299 frame AmokHuginnsson#2: 0x000000001b703f44 clickhouse-22.8-release`::abort_message(format=<unavailable>) at abort_message.cpp:78:5 frame AmokHuginnsson#3: 0x000000001b703dd4 clickhouse-22.8-release`demangling_terminate_handler() at cxa_default_handlers.cpp:67:21 frame AmokHuginnsson#4: 0x000000001b721063 clickhouse-22.8-release`std::__terminate(func=<unavailable>)()) at cxa_handlers.cpp:59:9 frame AmokHuginnsson#5: 0x000000001b720fce clickhouse-22.8-release`std::terminate() at cxa_handlers.cpp:88:17 frame AmokHuginnsson#6: 0x000000000a3b21db clickhouse-22.8-release`__clang_call_terminate + 11 frame AmokHuginnsson#7: 0x00000000189b1bfc clickhouse-22.8-release`replxx::Replxx::ReplxxImpl::~ReplxxImpl(this=0x00007f03fa945308) at replxx_impl.cxx:336:1 frame AmokHuginnsson#8: 0x00000000189b1ce9 clickhouse-22.8-release`replxx::Replxx::ReplxxImpl::~ReplxxImpl(this=0x00007f03fa945300) at replxx_impl.cxx:334:41 frame AmokHuginnsson#9: 0x00000000188b0644 clickhouse-22.8-release`ReplxxLineReader::~ReplxxLineReader() [inlined] std::__1::unique_ptr<replxx::Replxx::ReplxxImpl, void (*)(replxx::Replxx::ReplxxImpl*)>::reset(this=<unavailable>, __p=<unavailable>) at unique_ptr.h:315:7 frame AmokHuginnsson#10: 0x00000000188b0626 clickhouse-22.8-release`ReplxxLineReader::~ReplxxLineReader() [inlined] std::__1::unique_ptr<replxx::Replxx::ReplxxImpl, void (*)(replxx::Replxx::ReplxxImpl*)>::~unique_ptr(this=<unavailable>) at unique_ptr.h:269 frame AmokHuginnsson#11: 0x00000000188b0626 clickhouse-22.8-release`ReplxxLineReader::~ReplxxLineReader() [inlined] replxx::Replxx::~Replxx(this=<unavailable>) at replxx.hxx:76 frame AmokHuginnsson#12: 0x00000000188b0626 clickhouse-22.8-release`ReplxxLineReader::~ReplxxLineReader(this=0x00007ffd10038440) at ReplxxLineReader.cpp:229 frame AmokHuginnsson#13: 0x00000000158b2100 clickhouse-22.8-release`DB::ClientBase::runInteractive(this=0x00007ffd10038620) at ClientBase.cpp:2067:1 frame AmokHuginnsson#14: 0x000000000a4de372 clickhouse-22.8-release`DB::Client::main(this=0x00007ffd10038620, (null)=<unavailable>) at Client.cpp:261:9 frame AmokHuginnsson#15: 0x0000000018923a86 clickhouse-22.8-release`Poco::Util::Application::run(this=0x00007ffd10038620) at Application.cpp:334:8 frame AmokHuginnsson#16: 0x000000000a4ed341 clickhouse-22.8-release`mainEntryClickHouseClient(argc=39, argv=0x00007f03fa8201c0) at Client.cpp:1220:23 frame AmokHuginnsson#17: 0x000000000a3b17ab clickhouse-22.8-release`main(argc_=<unavailable>, argv_=<unavailable>) at main.cpp:449:12 frame AmokHuginnsson#18: 0x00007f03fb5aa083 libc.so.6`__libc_start_main + 243 frame AmokHuginnsson#19: 0x000000000a17032e clickhouse-22.8-release`_start + 46

siliconja · 2022-11-02T20:17:40Z

I created a Ubuntu PPA to build a 'libreplxx-dev' package (sudo apt install libreplxx-dev) and encountered this licensing issue. The debuild tool runs lintian on source packages and throws an error "E: replxx source: license-problem-convert-utf-code".

To address this I made patches that adopt the ConvertUTF.h and ConvertUTF.cpp files from the llvm-project commit 20451cb (llvm/llvm-project@20451cb) which have an updated license as described in previous comments.

Ubuntu PPA is here: https://launchpad.net/~siliconja/+archive/ubuntu/replxx/

minfrin · 2022-12-17T10:27:58Z

Based on @siliconja's recommendation above, here is a PR: #142

minfrin · 2023-06-20T11:24:41Z

Quick ping, any news on the PR above? Looks like lots of packaging pain gets unblocked when this is completed.

doug-moen · 2023-06-20T12:12:19Z

The PR is safe to merge without testing because the only change is to comments.

cstrahan mentioned this issue Apr 10, 2018

linenoise embeds non-free ConvertUTF{.cpp,.h} NixOS/nix#2014

Closed

AmokHuginnsson added enhancement help needed labels Jun 10, 2018

sbadia mentioned this issue Apr 2, 2020

[Feature] contrib/replxx/src/ConvertUTF.{h,cpp} are non-free rspamd/rspamd#3317

Closed

lighterowl mentioned this issue May 1, 2020

replace libtransmission/ConvertUTF.{c,h} with supported alternative transmission/transmission#612

Closed

amosbird pushed a commit to amosbird/replxx that referenced this issue Mar 15, 2021

Merge pull request AmokHuginnsson#12 from amosbird/master

254be98

Cherry-pick SIGWINCH handling

minfrin mentioned this issue Nov 11, 2021

Replxx submitted to Fedora #125

Open

This was referenced Sep 18, 2022

ConvertUTF.cpp is shipped with a non "University of Illinois Open Source License" compatible license llvm/llvm-project#32309

Closed

License of ConvertUTF.cpp and ConvertUTF.h simdutf/simdutf#170

Closed

dzaima mentioned this issue Dec 21, 2022

cbqn: add replxx option NixOS/nixpkgs#203989

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ConvertUTF.{cpp,h} are non-free #12

ConvertUTF.{cpp,h} are non-free #12

cstrahan commented Apr 10, 2018

AmokHuginnsson commented Apr 10, 2018 •

edited

Loading

dothebart commented Apr 11, 2018

doug-moen commented Jul 6, 2018

AmokHuginnsson commented Jul 7, 2018

doug-moen commented Jul 7, 2018

olegator77 commented Jul 27, 2018

LoganDark commented Sep 27, 2018

olegator77 commented Sep 27, 2018

LoganDark commented Sep 27, 2018

sbadia commented Apr 2, 2020

minfrin commented Nov 17, 2021

minfrin commented Nov 17, 2021

minfrin commented Nov 22, 2021

siliconja commented Nov 2, 2022

minfrin commented Dec 17, 2022

minfrin commented Jun 20, 2023

doug-moen commented Jun 20, 2023

ConvertUTF.{cpp,h} are non-free #12

ConvertUTF.{cpp,h} are non-free #12

Comments

cstrahan commented Apr 10, 2018

AmokHuginnsson commented Apr 10, 2018 • edited Loading

dothebart commented Apr 11, 2018

doug-moen commented Jul 6, 2018

AmokHuginnsson commented Jul 7, 2018

doug-moen commented Jul 7, 2018

olegator77 commented Jul 27, 2018

LoganDark commented Sep 27, 2018

olegator77 commented Sep 27, 2018

LoganDark commented Sep 27, 2018

sbadia commented Apr 2, 2020

minfrin commented Nov 17, 2021

minfrin commented Nov 17, 2021

minfrin commented Nov 22, 2021

siliconja commented Nov 2, 2022

minfrin commented Dec 17, 2022

minfrin commented Jun 20, 2023

doug-moen commented Jun 20, 2023

AmokHuginnsson commented Apr 10, 2018 •

edited

Loading