Approve PR only when all issues are below threshold severity #140
Conversation
kzaikin
force-pushed
the
approve_threshold
branch
from
66357a0 to
e2eba6b
Compare
|
Hi @kzaikin, thanks for this! FYI #95 is for a different usecase. In the SonarQube WebUI you can define lots of conditions when to accept the state of a project. Unfortunately this is not yet evaluated for preview builds. To be honest I would prefer to have the preview functionality from SonarQube side than to implement all kinds of conditions in the plugin. Do you have an urgent to use this new setting on your end or would you be fine with waiting for SonarSource to implement this on their side? |
|
@t-8ch I have a dozen teams inside my company waiting for this change |
|
@kzaikin Fair enough. |
kzaikin
force-pushed
the
approve_threshold
branch
from
e2eba6b to
8c4568e
Compare
|
Superseeded by #141 |
This will fix #95
These changes will modify default behavor which should be discussed.
If there are consumers who want PR to be approved when there are zero issues, then additional threshold value should be added. Something like
sonar.stash.reviewer.approval.issue.severity.thresholdHowever, this can be leveraged by lowing down
sonar.stash.task.issue.severity.thresholdMy opinion is to keep number of settings as low as possible and NOT to add any additional thresholds. Approving a PR as soon as there are no issue-tasks left looks quite natural so I'd stay with that as default behavior.