Skip to content
This repository has been archived by the owner on Jan 7, 2021. It is now read-only.

Tie approval to pass of the quality gate #95

Open
t-8ch opened this issue Dec 5, 2016 · 2 comments
Open

Tie approval to pass of the quality gate #95

t-8ch opened this issue Dec 5, 2016 · 2 comments
Milestone
Wishlist

Comments

@t-8ch
Copy link
Contributor

t-8ch commented Dec 5, 2016

We should change the logic of approval of a PR to the configured quality gate instead of the number of issues.

Cc @re-schneider @acopet
@t-8ch t-8ch added this to the Wishlist milestone Dec 5, 2016
@t-8ch t-8ch mentioned this issue Dec 5, 2016
Closed
@kzaikin
Copy link

kzaikin commented Jul 19, 2017

Is mentioned quality gate a sonar.stash.task.issue.severity.threshold value or a general sonar's quality gate?

@t-8ch
Copy link
Contributor Author

t-8ch commented Jul 19, 2017 •
edited
Loading

Currently only the threshold exists. The plan is to use a generic Quality Gate. But this is still missing features on SonarQube side.
See https://jira.sonarsource.com/browse/SONAR-6763

@kzaikin kzaikin mentioned this issue Jul 24, 2017
Closed
@t-8ch t-8ch mentioned this issue Oct 10, 2017
Closed
@t-8ch t-8ch mentioned this issue Sep 6, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Wishlist
Development

Successfully merging a pull request may close this issue.

Approve PR only when all issues are below threshold severity kzaikin/sonar-stash
2 participants
@t-8ch @kzaikin