Skip to content
This repository has been archived by the owner on Jan 7, 2021. It is now read-only.

Autodetect the stash settings #148

Open
t-8ch opened this issue Aug 24, 2017 · 4 comments
Open

Autodetect the stash settings #148

t-8ch opened this issue Aug 24, 2017 · 4 comments

Comments

@t-8ch
Copy link
Contributor

t-8ch commented Aug 24, 2017

When running under maven (and maybe other runners) we can access sonar.links.scm.
This should allow us to calculate the baseurl, repository and project automatically (if the setting is correctly configured)

@gauee
Copy link

gauee commented Oct 10, 2017

In my opinion it will be valuable to integrate it also with jenkins plugin stash-notifier. What do you think?

@t-8ch
Copy link
Contributor Author

t-8ch commented Oct 11, 2017

@gauee Could you elaborate this?

@gauee
Copy link

gauee commented Oct 11, 2017

@t-8ch
We run the sonar analysis on pull-requests from jenkins. To trigger the build we are using the stashPullRequestBuilderPlugin which have already the credentials settings.
The StashNotifier-plugin also have the stash credentials.

Im thinking about wrapping the execution of sonar goal into some jenkins plugin or adding the custom property to maven goal for loading some jenkins settings.

Which solution do you prefer, so I can try contribute with poc.

@t-8ch
Copy link
Contributor Author

t-8ch commented Oct 11, 2017

@gauee
I would prefer to keep any notion of the execution environment out of the sonar-stash plugin.
If you create a dedicated plugin this is completely fine (although I think it is probably overkill), but then the plugin would not really care, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants