Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename namespace Altinn.App.Core.Features.FileAnalyzis #856

Open
4 tasks
danielskovli opened this issue Oct 22, 2024 · 0 comments
Open
4 tasks

Rename namespace Altinn.App.Core.Features.FileAnalyzis #856

danielskovli opened this issue Oct 22, 2024 · 0 comments
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes kind/chore
Milestone

Comments

@danielskovli
Copy link
Contributor

danielskovli commented Oct 22, 2024

Description

The namespace Altinn.App.Core.Features.FileAnalyzis is misspelled and should be changed to Altinn.App.Core.Features.FileAnalysis. The containing folder should also be renamed.

Some files in the relevant folder have already taken this approach, but the result is that we now have two namespaces instead of one.

Consolidate this.

Additional Information

The hard part that makes this breaking, is that apps might use these classes, and to make this change, we need an upgrade tool that automatically fixes app code.

Tasks

  • Rename folder
  • Consolidate namespaces, removing the incorrect one
  • Write appropriate migration instructions and/or automation script

Acceptance Criterias

  • The lib consumer has a single namespace available for "File Analysis" and it is spelled correctly in British English
@danielskovli danielskovli added the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Oct 22, 2024
@danielskovli danielskovli added this to the 9.0.0 milestone Oct 22, 2024
@danielskovli danielskovli added kind/chore and removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. status/triage labels Oct 22, 2024
@ivarne ivarne added the breaking-change Label Pull requests with breaking changes. Used when generating releasenotes label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes kind/chore
Projects
Status: No status
Development

No branches or pull requests

2 participants