Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Post endpoint for creating data elements with PATCH like response #850

Open
ivarne opened this issue Oct 18, 2024 · 0 comments
Open
Assignees
Labels
kind/feature-request New feature or request org/krt Issues relevant for Finanstilsynet

Comments

@ivarne
Copy link
Member

ivarne commented Oct 18, 2024

Description

Service owners want to make changes to the dataElements when attachments gets uploaded, but the current POST endpoint on DataController, does not return the updated instance.Data (with new and deleted data elements), and changed validation issues.

The proposal is for a new URL to work in addition to the previous url where the dataType is a url parameter instead of a GET parameter.

// Previous url
/{org}/{app}/instances/{instanceOwnerPartyId}/{instanceGuid}/data?dataType=xx

// New url
/{org}/{app}/instances/{instanceOwnerPartyId}/{instanceGuid}/data/{dataType}

This means that we keep backwards compatibility for current API users, but new versions of frontend can use the new url to get a richer response back.

Additional Information

Another benefit is that we can (in the future) hack into the openApi generation process and registrer special urls for all DataTypes in applicationmetadata.json so that the actual data models is exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request org/krt Issues relevant for Finanstilsynet
Projects
Status: Done
Development

No branches or pull requests

1 participant