Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the designed ICorrespondenceClient #826

Closed
3 tasks done
martinothamar opened this issue Oct 10, 2024 · 2 comments
Closed
3 tasks done

Implement the designed ICorrespondenceClient #826

martinothamar opened this issue Oct 10, 2024 · 2 comments
Assignees
@martinothamar @danielskovli
Labels
feature Label Pull requests with new features. Used when generation releasenotes

Comments

@martinothamar
Copy link
Contributor

martinothamar commented Oct 10, 2024 •
edited
Loading

Implement ICorrespondenceClient as defined

Acceptance criteria

  • The client implementation is a sealed internal class
    It uses an internal variant of the IMaskinportenClient
  • It has robust error handling and telemetry
  • It can be used from within an Altinn app (Altinn.App.Core)
@martinothamar martinothamar moved this to 👷 In Progress in Team Apps Oct 18, 2024
@martinothamar martinothamar added feature Label Pull requests with new features. Used when generation releasenotes and removed status/triage labels Oct 18, 2024
@danielskovli danielskovli mentioned this issue Nov 8, 2024
Merged
5 tasks
@danielskovli
Copy link
Contributor

The acceptance criteria for using an internal variant of IMaskinportenClient I believe is no longer desired. In either case, that's not how the client has currently been implemented.

@martinothamar
Copy link
Contributor Author

agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinothamar martinothamar

@danielskovli danielskovli

Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
Team Apps
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinothamar @danielskovli