Validation that fails during IInstantiationValidator returns only the "text key" from resource-file back to the user in JSON-response.

[violaguttorm]

Description of the bug

We allow users to send in data via "maskinell innrapportering", such as doing it by Postman through pure JSON or creating their own front-end. This works fine for the most part, but while validation of most elements returns both the text key and the actual text the user should get back from the resource.[language].json file, when validation fails during the IInstantiationValidator process specifically the user is only given back the key. This can be cryptic, as the user has no idea what (for instance) rrh.notinregister means.

The source code is in this app: https://altinn.studio/repos/brg/rrh-innrapportering
URL in TT02: https://brg.apps.tt02.altinn.no/brg/rrh-innrapportering/

Steps To Reproduce

1. Connect to this app through Postman by using any virksomhet ENK.
2. Try creating a new Instance.
3. Observe the error message only returning the code.
   (You might also see it not being there in the JSON response given back through a regular failed instantiation by using the app itself, but I'm not sure.)

Additional Information

No response

[olemartinorg]

I believe this is the way it's always been. Systems delivering via API are expected to provide their own translations of these error codes to users. I changed this issue to be a feature request, and moved it to the app-lib-dotnet repo. Using translations from the resources files may be non-trivial if backend is to look up variables in texts as well.

[ivarne]

I think it would be relatively straightforward to add logic to the ValidationService so that a ValidationIssue with CustomTextKey set, can check the translations and fill the Description field with the correct value. Tagging as up for grabs, but it should wait for multiple data models, as validation service gets a major rewrite.