Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signering av valgfrie dataTypes #595

Closed
veronikaandersen opened this issue Apr 16, 2024 · 2 comments · Fixed by #622
Closed

Signering av valgfrie dataTypes #595

veronikaandersen opened this issue Apr 16, 2024 · 2 comments · Fixed by #622
Assignees
@bjorntore @HauklandJ
Labels
area/signing kind/feature-request New feature or request

Comments

@veronikaandersen
Copy link
Contributor

Description

Vi har behov for å signere dataelementer, dersom de er med. Altså valgfrie dataTypes.

Når man setter opp signering, definerer man hvilke dataTypes som skal signeres. Dersom dataTypes i denne listen er valgfrie - eks de er konfigurert med minCount=0, får man feil pga manglende dataelement for signering.
Signeringen tar tilsynelatende ikke hensyn til konfigurasjonen av dataTypes i applicationmetadata.json.

Eksempel: Valgfri dataType
image

Signering task
image

Process next med signering - uten dataelement av typen IG
image

Process next med signering - med dataelement av typen IG på instansen
image

Additional Information

No response
@veronikaandersen veronikaandersen added the kind/feature-request New feature or request label Apr 16, 2024
@RonnyB71 RonnyB71 moved this to 📈 Todo in Team Apps Apr 25, 2024
@HauklandJ HauklandJ self-assigned this Apr 25, 2024
@HauklandJ HauklandJ moved this from 📈 Todo to 👷 In Progress in Team Apps Apr 25, 2024
@HauklandJ
Copy link
Contributor

Reprodusert.

@HauklandJ HauklandJ moved this from 👷 In Progress to 🔎 Review in Team Apps Apr 30, 2024
@HauklandJ HauklandJ mentioned this issue Apr 30, 2024
Merged
5 tasks
@HauklandJ HauklandJ linked a pull request May 2, 2024 that will close this issue
Signing optional data types #622
Merged
5 tasks
@HauklandJ HauklandJ moved this from 🔎 Review to 🧪 Test in Team Apps May 2, 2024
@bjorntore
Copy link
Contributor

Test: Får ikke feilmelding lenger. 👍Det ble generert en signature.json med tom dataElementSignatures array.

@bjorntore bjorntore moved this from 🧪 Test to ✅ Done in Team Apps May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorntore bjorntore

@HauklandJ HauklandJ

Labels
area/signing kind/feature-request New feature or request
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signing optional data types Altinn/app-lib-dotnet
4 participants
@bjorntore @veronikaandersen @HauklandJ @HanneLauritsen1967