Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing TelemetryClient and prometheus-net #592

Open
HauklandJ opened this issue Apr 15, 2024 · 2 comments
Open

Removing TelemetryClient and prometheus-net #592

HauklandJ opened this issue Apr 15, 2024 · 2 comments
Assignees
Labels
feature Label Pull requests with new features. Used when generation releasenotes kind/chore

Comments

@HauklandJ
Copy link
Contributor

HauklandJ commented Apr 15, 2024

Description

Part of the Monitoring epic.

Find all dependencies in app-developers apps to TelemetryClient and note if there are any hard dependencies - e.g. dependecy injection.

In scope

The usage of TelemetryClient in app developers apps running on TEs test or production clusters.

Out of scope

Any custom use of TelemetryClient - When a the app code creates a new instance of TelemetryClient.

Apps which are not deployed to any environment(?)

Additional Information

No response

Analysis

Initial analysis:

  1. Clone all repositories from Gitea (NOTE: All open repos - no auth)
  2. Search for 'TelemetryClient'

Findings:
Lots of apps creating a new instance of TelemetryClient in Program.cs (using a dated version of the nuget-packages)
One case of an app creating a new instance of TelemetryClients in Startup.cs.
No cases of dependency injection.

Preliminary conclusion: Removing TelemetryClient is not a breaking change.

Conclusion

No response

@HauklandJ HauklandJ added status/draft Status: When you create an issue before you have enough info to properly describe the issue. feature Label Pull requests with new features. Used when generation releasenotes labels Apr 15, 2024
@HauklandJ HauklandJ moved this to 👷 In Progress in Team Apps Apr 15, 2024
@HauklandJ
Copy link
Contributor Author

HauklandJ commented Apr 15, 2024

Question: As seen in the Analysis part of the issue, only open repos were cloned. Are there any repositories which require auth? @ivarne maybe you know the answer?

@ivarne
Copy link
Member

ivarne commented Apr 15, 2024

I think so. I've just assumed those who might have locked down access to their repositories don't want us to run such analyses, but I have not confirmed that.

Anyway, is the issue about not using AI and TememetryClient, or to use a wrapper for our code that allows future changes?

@HauklandJ HauklandJ removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. status/triage labels Apr 16, 2024
@HanneLauritsen1967 HanneLauritsen1967 moved this from 👷 In Progress to ✅ Done in Team Apps Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Label Pull requests with new features. Used when generation releasenotes kind/chore
Projects
Status: Done
Development

No branches or pull requests

3 participants