Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent service from being manually instantiated #361

Closed
2 tasks
RonnyB71 opened this issue Nov 23, 2023 · 3 comments · Fixed by Altinn/app-frontend-react#2209
Closed
2 tasks

Prevent service from being manually instantiated #361

RonnyB71 opened this issue Nov 23, 2023 · 3 comments · Fixed by Altinn/app-frontend-react#2209
Assignees
Labels
feature-complete kind/user-story Used for issues that describes functionality for our users.

Comments

@RonnyB71
Copy link
Member

Description

Services based on subscription should not be allowed to instantiate manually. Subscription is this case means that the instance are created by the service owner on behalf of the reportee. The instance is the shown in the Altinn Inbox as a element that needs attention and should be filled out. In Altinn 2 there is a setting called "Kun tilgjengelig for abonnementstjeneste", but currently Altinn 3 iss missing this feature. In order to easily test forms like this it should be possible to instantiate them in a test environment.

Additional Information

As a reference for services using this in Altinn 2 see KRT-10001 and KRT-1007.

Tasks

No response

Acceptance Criterias

  • A setting that disallows manual instantiation and shows an error message to the user if manual instantiation is tried.
  • It should be allowed to use copy from previous instances as long as this was created as a subscription service
@RonnyB71 RonnyB71 added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. feature-complete labels Nov 23, 2023
@tjololo
Copy link
Member

tjololo commented Nov 30, 2023

The scenario where only the service owner is allowed to instantiate and not the end user should be possible to achieve with a authorization rule I think.
But as we cannot differentiate the auth rules based on the environment the same rules would apply in all environments leaving the "possible to instantiate them in a test environment" as a todo.
The Copy operation is tied to the instantiate permission so I think that is also something we would need to adress, but not 100% sure.

@martinothamar martinothamar self-assigned this May 30, 2024
@martinothamar martinothamar moved this to 👷 In Progress in Team Apps May 30, 2024
@martinothamar
Copy link
Contributor

martinothamar commented May 31, 2024

Looks like copying is done in two steps

  • Create the new instance as normal
  • Copy over data

So if we're going to use XACML and and the instantiate action for this I guess we have to differentiate a "copy creation" and the "normal creation"

@martinothamar
Copy link
Contributor

Released in v8.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-complete kind/user-story Used for issues that describes functionality for our users.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants