Fix DevTools in subform #2819
Fix DevTools in subform #2819
Conversation
bjosttveit
requested review from
olemartinorg,
adamhaeger,
danielskovli and
HauklandJ
| const hasPresentation = useHasPresentation(); | ||
|
|
||
| if (overriddenDataModelUuid) { |
There was a problem hiding this comment.
All of these task-store checks in the loader was something we added to avoid the "page is loading" for each subform during the PDF render.
Have you tested how this now looks during PDF generation?
There was a problem hiding this comment.
Good point. Also counts for summaries of subforms.
There was a problem hiding this comment.
The summary table looks good, but in PDF it looks weird indeed. Good catch. What component is used here?
There was a problem hiding this comment.
What do you think of this? As a compromise. Still showing the loader, but not the Presentation around it.
Summary:
PDF:
There was a problem hiding this comment.
Unless i am missing something @danielskovli
There was a problem hiding this comment.
@bjosttveit @olemartinorg Last time I was involved in this part of the code, the ready-for-print mechanism waited for all subform data to finish loading 👌
The Loader modifications were only visual if I remember correctly. Worth noting that the overriddenTaskId check was already in there, I think perhaps @adamhaeger had added it as part of the Summary2 feature.
There was a problem hiding this comment.
overriddenTaskId is (or was?) needed to render summary of a previous task.
There was a problem hiding this comment.
I like the new skeleton loader 👍
There was a problem hiding this comment.
Still is, this will just show a loader instead of null while it loads. Due to useHasPresentation it should just show the loader and not the Presentation container around it. In PDF however we don't have any Presentation container, so I added a DummyPresentation that only sets the provider so that loading will not create its own Presentation there either
|
Description
Fixes dev-tools crashing in subform. Also makes the subform-loading look a bit better by not showing an empty form container.
Added an error boundary inside of the dev tools panel as well, so errors like this are less annoying in the future
Cleaned up dev tools component by removing
{children}since we no longer wrap the application in it.Related Issue(s)
Verification/QA
kind/*label to this PR for proper release notes grouping