Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move filenameUtils from shared to studio-pure-functions #14134

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

standeren
Copy link
Contributor

Description

Move filenameUtils from shared to studio-pure-functions in order to use a file name util function in the content library.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/text-editor Area: Related to creating, translating and editing texts. solution/studio/designer Issues related to the Altinn Studio Designer solution. area/version-control Area: Related to version control for files in apps. frontend labels Nov 22, 2024
@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-core skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (6a1351e) to head (d9d6ec0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14134   +/-   ##
=======================================
  Coverage   95.31%   95.32%           
=======================================
  Files        1779     1780    +1     
  Lines       23156    23160    +4     
  Branches     2689     2689           
=======================================
+ Hits        22072    22078    +6     
  Misses        835      835           
+ Partials      249      247    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@framitdavid framitdavid merged commit 77e8aa2 into main Nov 22, 2024
10 checks passed
@framitdavid framitdavid deleted the move-fileNameUtils-to-pure-functions branch November 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/text-editor Area: Related to creating, translating and editing texts. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/version-control Area: Related to version control for files in apps. frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants