Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deleted data model from signing tasks #13105

Closed
mlqn opened this issue Jul 5, 2024 · 3 comments · Fixed by #13156
Closed

Remove deleted data model from signing tasks #13105

mlqn opened this issue Jul 5, 2024 · 3 comments · Fixed by #13156
Assignees
Labels
added-to-sprint area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). kind/bug Used when there is a defect / something is not working as it should. status/triage

Comments

@mlqn
Copy link
Contributor

mlqn commented Jul 5, 2024

Description of the bug

Deleting a data model or a component or should remove the deleted data types from the dataTypesToSign properties.

EDIT: Updating a component id should also update the data types of the dataTypesToSign properties.

Steps To Reproduce

delete-data-model.mov

Additional Information

No response

@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). added-to-sprint labels Jul 5, 2024
@mlqn mlqn added this to Team Studio Jul 5, 2024
@mlqn mlqn added the area/data-modeling Area: Related to data models - e.g. create, edit, use data models. label Jul 5, 2024
@mlqn mlqn moved this to 👷 In Progress in Team Studio Jul 5, 2024
@mlqn mlqn self-assigned this Jul 5, 2024
@mlqn mlqn linked a pull request Jul 15, 2024 that will close this issue
3 tasks
@mlqn mlqn moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 16, 2024
@mlqn mlqn removed their assignment Jul 16, 2024
@mlqn mlqn moved this from 🔎 Review to 👷 In Progress in Team Studio Jul 16, 2024
@mlqn mlqn assigned mlqn and unassigned mlqn Jul 16, 2024
@mlqn mlqn moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 16, 2024
@mlqn mlqn moved this from 🔎 Review to 👷 In Progress in Team Studio Jul 17, 2024
@mlqn mlqn self-assigned this Jul 17, 2024
@mlqn mlqn moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 17, 2024
@mlqn mlqn moved this from 🔎 Review to 👷 In Progress in Team Studio Jul 17, 2024
@mlqn mlqn moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 17, 2024
@mlqn mlqn removed their assignment Jul 17, 2024
@mlqn mlqn moved this from 🔎 Review to 👷 In Progress in Team Studio Jul 17, 2024
@mlqn mlqn assigned mlqn and unassigned mlqn Jul 17, 2024
@mlqn mlqn moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 17, 2024
@ErlingHauan ErlingHauan assigned ErlingHauan and mlqn and unassigned ErlingHauan Jul 19, 2024
@TomasEng TomasEng assigned TomasEng and mlqn and unassigned TomasEng Jul 25, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jul 29, 2024
@mlqn mlqn removed their assignment Jul 30, 2024
@nkylstad nkylstad self-assigned this Aug 2, 2024
@nkylstad
Copy link
Member

nkylstad commented Aug 2, 2024

Tested OK in dev:

  • Added a signing task, and set data model from data task as dataTypesToSign together with ref-data-as-pdf data type.
  • Navigated to datamodels page and deleted the data model
  • Navigated back to process editor
  • Result:
    • Data task no longer had connected data model (existing functionality)
    • Signing task only had ´ref-data-as-pdf`, data model had been removed from list as expected.

Tested OK, but unsure about correct behaviour here:

  • Added a FileUpload component in form, and connected signing task to the corresponding data type
  • Changed the ID of the FileUpload component
  • Result:
    • data type for fileUpload component was removed from dataTypesToSign on signing task.

In this case I would expect the data type to be updated, rather than removed.

@nkylstad nkylstad moved this from 🧪 Test to 👀 Test feedback in Team Studio Aug 2, 2024
@nkylstad nkylstad assigned mlqn and unassigned nkylstad Aug 2, 2024
@mlqn mlqn mentioned this issue Aug 13, 2024
3 tasks
@mlqn
Copy link
Contributor Author

mlqn commented Aug 14, 2024

Nice catch! This PR will fix the issue: #13357

@mlqn mlqn assigned mlqn and unassigned mlqn Aug 19, 2024
@nkylstad
Copy link
Member

Re-tested this now with changing FileUpload component, it now updates the data type in the signing task as expected!

@nkylstad nkylstad moved this from 👀 Test feedback to ✅ Done in Team Studio Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). kind/bug Used when there is a defect / something is not working as it should. status/triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants