Not possible to delete a field from a type that is in use

[nkylstad]

Description of the bug

In the datamodels tool.

Steps To Reproduce

1. Go to an app with a datamodel
2. Create a type with several fields
3. Drag the type into the data model so that the data model has a field that references the type
4. Go back to the type
5. See that the delete icon for the type is disabled as expected (since the type is in use)
6. Try to delete one of the fields within the type
7. See that the field is not deleted
8. See that an error message is printed to the console

Additional Information

No response

[nkylstad]

Ref. today's session on error messages 😊
I think we should look at the warning message here again.

A suggestion from me:
"Feltet du prøver å slette tilhører en aktiv type som er i bruk i datamodellen. Om du sletter dette feltet vil det slettes alle steder i datamodellen der denne typen er i bruk. Vil du slette feltet?"

Feel free to disagree or iterate on the suggestion 😊

EDIT: Tested actually deleting the field, which works as expected!

[framitdavid]

Ref. today's session on error messages 😊 I think we should look at the warning message here again.

A suggestion from me: "Feltet du prøver å slette tilhører en aktiv type som er i bruk i datamodellen. Om du sletter dette feltet vil det slettes alle steder i datamodellen der denne typen er i bruk. Vil du slette feltet?"

Feel free to disagree or iterate on the suggestion 😊

EDIT: Tested actually deleting the field, which works as expected!

Great suggestion! Fixed in this PR

[framitdavid]

It should be ready for retest in minutes, #12245

[nkylstad]

Great!