Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic code changes #287

Merged
merged 1 commit into from
Oct 25, 2023
Merged

cosmetic code changes #287

merged 1 commit into from
Oct 25, 2023

Conversation

acn-sbuad
Copy link
Contributor

Description

Fixed messages and removed unused references

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.3% 97.3% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@HenningNormann HenningNormann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har du funnet ut hva som var problemet med config settingene og hvorfor disse endringene løser det?

@acn-sbuad
Copy link
Contributor Author

acn-sbuad commented Oct 25, 2023

Har du funnet ut hva som var problemet med config settingene og hvorfor disse endringene løser det?

Nei, @HenningNormann. Dette var ikke et tiltak for å fikse config settingen. Det må påvirkes av hvilke tester som kjører i parallell tror jeg og oppstår kun en gang i blant. Tenker det ikke er verdt innsatsen i å grave videre. Skaper det mye støy framover vil aksjonen vår være å slette den aktuelle flaky testen og heller leve med noe lavere testdekning

@acn-sbuad acn-sbuad merged commit 3d3829f into main Oct 25, 2023
9 checks passed
@acn-sbuad acn-sbuad deleted the chore/fixed-messages branch October 25, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants