Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression testing of Notifications with Profile configured to use local KRR cop as data source #616

Closed
5 of 10 tasks
Tracked by #406
olebhansen opened this issue Sep 24, 2024 · 0 comments
Closed
5 of 10 tasks
Tracked by #406
Assignees

Comments

@olebhansen
Copy link

olebhansen commented Sep 24, 2024

Blocked by Altinn/altinn-profile#176

Once our new KRR replica is available, we should refactor notifications to use this as a datasource in applicable cases (when the recipient is a person identified by SSN).

Tasks

  • Check if Altinn 2 is using the KRR dates: "updated" and "verified" and how if so.
  • Ensure that Notifications handles the newly declared "nullability" in properties UserId, NationalIdentityNumber, MobileNumber, and Email
  • Test order creation that involves users having null-values for UserId, NationalIdentityNumber, MobileNumber, and/or Email

Acceptance criteris:

  • Notification uses Altinn3 KRR replica when this is the only datasource needed (persons by SSN)

Things to discuss

  • Threat modelling
    Discuss possible security issues
  • Documentation
  • Do we need to update documentation in altinn docs?
  • Do we need Internal documentation (confluence)?
  • We do not need to update documentation or write internal documentation
  • External tests
  • Should new functionality be Regression tested?
  • Should new functionality be included in Usecase tests?
  • Do not need to update automated tests
  • Acceptance criteria
    Does the issue have defined acceptance criteria?
@olebhansen olebhansen assigned olebhansen and unassigned olebhansen Sep 24, 2024
@NathalieFroissart NathalieFroissart changed the title Modify Norifications to use new KRR endpoint in Altinn 3 Modify Notifications to use new KRR endpoint in Altinn 3 Oct 3, 2024
@SandGrainOne SandGrainOne changed the title Modify Notifications to use new KRR endpoint in Altinn 3 Regression testing of Notifications with Profile configured to use local KRR cop as data source Nov 8, 2024
@Ahmed-Ghanam Ahmed-Ghanam self-assigned this Nov 11, 2024
@Ahmed-Ghanam Ahmed-Ghanam removed their assignment Nov 13, 2024
@tba76 tba76 self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants