Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #4

Open
raunilillemets opened this issue Mar 31, 2017 · 1 comment
Open

Typo #4

raunilillemets opened this issue Mar 31, 2017 · 1 comment

Comments

@raunilillemets
Copy link

raunilillemets commented Mar 31, 2017

Hello and thanks for Your interesting book! I am trying to use the Python3 version of the code and I found the following typo:

Shouldn't line 516 in "thinkplot.py" be:
xs = np.delete(xs, 0)
instead of:
xs = xp.delete(xs, 0)
?

If I am mistaken, how should the correct variant be?

raunilillemets pushed a commit to raunilillemets/ThinkBayes2 that referenced this issue Mar 31, 2017
@raunilillemets
Copy link
Author

raunilillemets commented Mar 31, 2017

I created a pull request in the hope that I made the correction (wait for it) correctly.

I know its a rather minor thing for creating a pull request, but I am just trying to get accustomed with GitHub; if there are any best practices, etc., that I should now, then shoot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant