Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolver]: Support custom sandbox #5348

Merged
merged 4 commits into from
Dec 1, 2024
Merged

[Resolver]: Support custom sandbox #5348

merged 4 commits into from
Dec 1, 2024

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Dec 1, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Adding param to support custom sandbox
  • Adding clarity to resolver docs

Link of any specific issues this addresses
#5331


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ae70abc-nikolaik   --name openhands-app-ae70abc   docker.all-hands.dev/all-hands-ai/openhands:ae70abc

@malhotra5 malhotra5 requested a review from neubig December 1, 2024 18:17
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@malhotra5 malhotra5 enabled auto-merge (squash) December 1, 2024 19:54
@malhotra5 malhotra5 merged commit 64a7fef into main Dec 1, 2024
14 checks passed
@malhotra5 malhotra5 deleted the resolver/env-support branch December 1, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants