feature: Condenser Interface and Defaults #5306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add abstract Condenser base class - Add NoopCondenser, RecentEventsCondenser, and LLMCondenser implementations - Add configuration system using pydantic models - Make NoopCondenser the default - Add comprehensive unit tests
- Replace const parameter with Literal type in condenser configs - Update from_config to check type field directly - Fix Event creation in LLMCondenser to use direct attribute assignment - Update memory module imports
…ndling - Move condenser_config.py from memory/ to core/config/ - Rename AgentConfig.condenser_config to condenser - Add proper handling of Pydantic models in env var loading - Add test for condenser config loading - Add example of LLM condenser config in config.toml
enyst
reviewed
Nov 27, 2024
| from openhands.core.config.llm_config import LLMConfig | ||
|
|
||
|
|
||
| class CondenserConfig(BaseModel): |
There was a problem hiding this comment.
Just a small detail, you may want to check this bit, the other config classes are dataclasses instead of BaseModel. Some bunch of utility code works with them as dataclasses and assumes they all are, I think - stuff like ensure that their values are loaded correctly etc, e.g.
OpenHands/openhands/core/config/utils.py
Line 42 in f0ca223
There was a problem hiding this comment.
I'll double-check. Easy enough to change to data classes if needed!
|
This is exciting and beautiful ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR adds an abstract memory condenser interface, provides a few default condenser implementations, and updates the CodeActAgent to use the configured condenser during inference.
Condensers exist to reduce the size of the state that must be considered during an agent's
stepfunction. They provide acondense: list[Event] -> list[Event]function that can perform an arbitrary transformation on thehistoryof a state before it is seen by an agent, including:LLMCondenser),NoOpCondenser).This does not change the underlying state, but can be used by agents as a form of attention and to manage the size of the context in long-running jobs. For an example, see the implementation in
CodeActAgent-- the default condenser is theNoOpCondenser, so while the agent is "using the condenser" there is no visible change unless otherwise configured. Currently, condensers must be set by manually initializing anAgentConfigobject.The intent of this PR is to lay the groundwork for an evaluation framework that will let us assess the efficacy of different condenser implementations and, if warranted, support switching between condensers with simple configuration options.
Link of any specific issues this addresses