Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows using the github-resolver without a PAT #5278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

regismesquita
Copy link

Allows using the github-resolver without a PAT

@neubig
Copy link
Contributor

neubig commented Nov 26, 2024

Hey @regismesquita , thanks for this! Quick question, after this PR will PRs sent to this repo still come from openhands-agent? I'd like to preserve that possibility, even if it's optional.

@regismesquita
Copy link
Author

@neubig, the PRs were always assigned to the PAT owner during my runs, never to the openhands-agent user. Therefore, they will be associated with the GitHub Actions user.

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, could we please change this so that when PAT_TOKEN is set, it uses PAT_TOKEN, and if not it uses the github token? That will maintain the current behavior if PAT_TOKEN is set.

@openhands-agent could you take a first stab at this?

@enyst
Copy link
Collaborator

enyst commented Nov 26, 2024

OK, could we please change this so that when PAT_TOKEN is set, it uses PAT_TOKEN, and if not it uses the github token? That will maintain the current behavior if PAT_TOKEN is set.

@openhands-agent could you take a first stab at this?

I'm not sure if the call in the body of a comment is on pypi yet... @openhands-agent-exp you have been called to help, can you solve the PAT_TOKEN as pointed out above?

Copy link
Contributor

OpenHands started fixing the pr! You can monitor the progress here.

@regismesquita
Copy link
Author

@neubig if the PAT_TOKEN is set it is to be used, I was referring to when using the github token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants