-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LocalRuntime and rename EventStreamRuntime to DockerRuntime #5284
base: main
Are you sure you want to change the base?
Conversation
…ntime - Add new LocalRuntime implementation that runs action_execution_server directly on host - Rename EventStreamRuntime to LocalDockerRuntime for clarity - Move runtime implementations to dedicated directories - Update documentation to reflect runtime changes
- Update imports to use LocalDockerRuntime and LocalRuntime - Add LocalRuntime to get_runtime_classes() - Update _close_test_runtime to handle LocalDockerRuntime
- Add proper type hints for server_process - Fix stdout access safety - Fix async/await type hints - Improve error handling
… LocalDockerRuntime
New OpenHands update |
@openhands-agent This PR tests fail with
Fix this error. Keep your changes minimal. |
@openhands-agent We have done a lot to fix the original. This PR is doing these:
The PR is mostly finished now. It has only one detail that went wrong: instead of the name LocalDockerRuntime, we now want the name DockerRuntime. Find all occurrences and fix them. Additionally, look also for the name EventStreamRuntime, and if you find any, update it to the new name, DockerRuntime. |
… LocalDockerRuntime
|
@enyst going back from thanksgiving break and see this.. I'm very impressed :D - I think we can just see if we can run the same suites of runtime tests on LocalRuntime 🤔 |
… LocalDockerRuntime
@openhands-agent Can you try to set up environment first, then try to run
And get the testcase to pass? Note you are allowed to override some of the |
New OpenHands update |
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
This PR adds a new LocalRuntime implementation and renames EventStreamRuntime to LocalDockerRuntime for better clarity.
Changes
Benefits
Issue fixed: #3903
To run this PR locally, use the following command: