[O2B-1327] User interface for setting GAQ detectors #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsalonx
changed the title
graduta
requested changes
Aug 8, 2024
There was a problem hiding this comment.
There are some improvements that could and should be done on the UI:
- given that you already load the run data, thus detectors part of that run, should the modal not include only those detectors? Otherwise we always display a DB error message. It will be easier for user to know which eligible detectors there are to select from;
- please have a look at display flex and justify-content so that checkboxes are aligned vertically with the label.
graduta
previously approved these changes
Aug 9, 2024
graduta
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: