Wrapper struct for models of a theory #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## symbolic_model_explicit #180 +/- ##
===========================================================
+ Coverage 95.04% 95.09% +0.05%
===========================================================
Files 38 38
Lines 2299 2345 +46
===========================================================
+ Hits 2185 2230 +45
- Misses 114 115 +1 ☔ View full report in Codecov by Sentry. |
kris-brown
force-pushed
the
symbolic_model_explicit
branch
from
a7d785c to
69dc438
Compare
added 4 commits
December 11, 2024 17:46
remove Wrapper abstract type As a macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #178
One can declare that
Foois a single-field struct which wraps models ofThCategoryviaThCategory.Meta.@wrapper Foo. This type can be a subtype of an abstract type too:ThCategory.Meta.@wrapper Foo <: MyAbsType.We may also want to generate a wrapper struct which has type parameters for the associated Julia types, so
ThCategory.Meta.@typed_wrapper Foomeans thatFoo(FinCatC()) isa Foo{Int,Vector{Int}}It's unclear if we should just have the typed version and, if one doesn't need to use the type parameters, one can ignore them.