Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper struct for models of a theory #180

Open
wants to merge 4 commits into
base: symbolic_model_explicit
Choose a base branch
from

Conversation

kris-brown
Copy link
Collaborator

@kris-brown kris-brown commented Dec 9, 2024

This addresses #178

One can declare that Foo is a single-field struct which wraps models of ThCategory via ThCategory.Meta.@wrapper Foo. This type can be a subtype of an abstract type too: ThCategory.Meta.@wrapper Foo <: MyAbsType.

We may also want to generate a wrapper struct which has type parameters for the associated Julia types, so ThCategory.Meta.@typed_wrapper Foo means that Foo(FinCatC()) isa Foo{Int,Vector{Int}}

It's unclear if we should just have the typed version and, if one doesn't need to use the type parameters, one can ignore them.

@kris-brown kris-brown linked an issue Dec 9, 2024 that may be closed by this pull request
@kris-brown kris-brown self-assigned this Dec 9, 2024
@kris-brown kris-brown added the enhancement New feature or request label Dec 9, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.09%. Comparing base (69dc438) to head (cc44137).

Files with missing lines Patch % Lines
src/syntax/TheoryInterface.jl 98.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           symbolic_model_explicit     #180      +/-   ##
===========================================================
+ Coverage                    95.04%   95.09%   +0.05%     
===========================================================
  Files                           38       38              
  Lines                         2299     2345      +46     
===========================================================
+ Hits                          2185     2230      +45     
- Misses                         114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown force-pushed the symbolic_model_explicit branch from a7d785c to 69dc438 Compare December 12, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper structs for models of a particular theory
1 participant