Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WithModel dispatch to accept subtypes #170

Open
wants to merge 2 commits into
base: import_fix
Choose a base branch
from

Conversation

kris-brown
Copy link
Collaborator

Addresses #169

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (a129cb4) to head (be9b7d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   93.85%   95.56%   +1.71%     
==========================================
  Files          38       38              
  Lines        2229     2234       +5     
==========================================
+ Hits         2092     2135      +43     
+ Misses        137       99      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown linked an issue Dec 7, 2024 that may be closed by this pull request
@kris-brown kris-brown self-assigned this Dec 9, 2024
@kris-brown kris-brown added the enhancement New feature or request label Dec 9, 2024
@kris-brown kris-brown changed the base branch from main to import_fix December 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithModel dispatch is too strict, ought accept subtypes
1 participant