Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make_alias_definitions for catlab compatibility #133

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

kris-brown
Copy link
Collaborator

A small change: originally, for a binding with name declaring an alias to Hom, we would create code to make an alias definition if the name was not found in ext_functions (the explicitly imported things in the @instance declaration).

This was changed in a PR of mine because it seemed like one would more likely write import Hom rather than import →. To my surprise, this is causing regressions in Catlab. I haven't gotten to the bottom of why, but for the time being I'm rolling back this change.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed21d2e) 96.61% compared to head (1b89721) 96.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          38       38           
  Lines        2067     2067           
=======================================
  Hits         1997     1997           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kris! Recommending to merge to fix the problem in Catlab, but if there is a lingering question here it may be worth creating an issue to track it.

@kris-brown kris-brown merged commit 8315bb9 into main Dec 7, 2023
9 checks passed
@epatters epatters deleted the catlabcompat branch December 7, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants