Work on summation inference #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will now only propagate form types. If a single form is present then this will be inferred. If there are no forms then we skip and if there are multiple forms we error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 84.62% 84.68% +0.06%
==========================================
Files 12 12
Lines 761 764 +3
==========================================
+ Hits 644 647 +3
Misses 117 117 ☔ View full report in Codecov by Sentry. |
This brings its function signature more in line with the other inference applications.
lukem12345
reviewed
Jun 21, 2024
I'm testing the use of getter functions to return us type groups to avoid us having to type them out. We can add more groups if needed.
lukem12345
reviewed
Jun 24, 2024
lukem12345
reviewed
Jun 24, 2024
|
We can clean up the setting of the |
lukem12345
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the summation inference code. This will now only propagate form types and do basic type checking.