Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on summation inference #48

Closed
wants to merge 4 commits into from
Closed

Work on summation inference #48

wants to merge 4 commits into from

Conversation

GeorgeR227
Copy link
Contributor

Cleans up the summation inference code. This will now only propagate form types and do basic type checking.

This should help solve problems in type inference regarding typing rules doing strange things.
Also tests for the function itself
Also added broken test for strange summation behavior.
This will now only propagate form types. If a single form is present then this will be inferred. If there are no forms then we skip and if there are multiple forms we error.
@GeorgeR227 GeorgeR227 closed this Jun 21, 2024
@lukem12345
Copy link
Member

@GeorgeR227 Your last few PRs have had spurious changes to lines. I guess this is because of line ending encodings or something. I think you can configure your git client to ignore these.

@GeorgeR227
Copy link
Contributor Author

I think actually this is to do with hanging whitespace at the end of lines. My git client does tell me if the encoding are different.

However I agree with you in that these are annoying now because they aren't the purpose of these PRs.

@GeorgeR227
Copy link
Contributor Author

Also I'm moving this PR to #49.

@lukem12345
Copy link
Member

I think actually this is to do with hanging whitespace at the end of lines. My git client does tell me if the encoding are different.

Yeah maybe spot check a few of these. It usually highlights when whitespace inside of line is added or removed.

It makes the git blame misleading when tracking things down.

@GeorgeR227
Copy link
Contributor Author

Yeah this is the case, if you check

Trivial = @decapode begin

there is some whitespace at the end but if I edit the file in anyway it's removed and caught in the commit.

@lukem12345
Copy link
Member

Ok, maybe turn off the aggressive linting setting or just use git add at the command line instead.

@GeorgeR227
Copy link
Contributor Author

I'll open a linting issue with a reference this problem. We have an issue about this in Decapodes but not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants