Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Catlab.Theories imports #175

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Remove Catlab.Theories imports #175

merged 2 commits into from
Nov 7, 2023

Conversation

lukem12345
Copy link
Member

Anyone who uses LinearAlgebra and Catlab will receive a warning about \cdot being defined by both packages.

The particular warning generated by Decapodes in issue #157 can be avoided by removing some unnecessary imports from Catlab.Theories.

@lukem12345 lukem12345 self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef0b7f1) 74.42% compared to head (be265c8) 74.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files           9        9           
  Lines        1122     1122           
=======================================
  Hits          835      835           
  Misses        287      287           
Files Coverage Δ
src/Decapodes.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukem12345
Copy link
Member Author

Looking at the test CI/CD, the warning does not appear. This is ready to merge upon review.

@jpfairbanks jpfairbanks merged commit 88b1874 into main Nov 7, 2023
9 checks passed
@epatters epatters deleted the llm/cdot branch November 7, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants