Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplace DPO rewrite method that returns maps #51

Open
slwu89 opened this issue Mar 5, 2024 · 1 comment
Open

Inplace DPO rewrite method that returns maps #51

slwu89 opened this issue Mar 5, 2024 · 1 comment

Comments

@slwu89
Copy link
Member

slwu89 commented Mar 5, 2024

In the Inplace module https://github.com/AlgebraicJulia/AlgebraicRewriting.jl/blob/main/src/rewrite/Inplace.jl it would be nice to have something like rewrite_match_maps! which does the rewrite inplace but returns the maps like rewrite_match_maps does (https://github.com/AlgebraicJulia/AlgebraicRewriting.jl/blob/main/src/rewrite/DPO.jl).

This is helpful for using inplace rewriting with the incremental homset updating, for example. I'd be happy to look into how to make this contribution, but I don't understand what is going on in the Incremental module; with some rough guidance I could get started.

@kris-brown
Copy link
Collaborator

@epatters notes: we could have an ACSets.jl method which copies an ACSet in a way that they share the underlying columns but have independent bitmasks (such that much less data needs to be copied, overall), such that the same ACSet columns could be used in the domain and codomain.

Alternatively I'm sure we can find a way to make the incremental hom set code not require ACSetTransformations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants