Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance warning from SciML #125

Open
jpfairbanks opened this issue Jun 22, 2023 · 0 comments
Open

Performance warning from SciML #125

jpfairbanks opened this issue Jun 22, 2023 · 0 comments
Labels

Comments

@jpfairbanks
Copy link
Member

628
     Testing Running tests...
[629](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:632)
Test Summary: | Pass  Total   Time
[630](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:633)
UWDDynam      |   55     55  38.5s
[631](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:634)
Test Summary: | Pass  Total   Time
[632](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:635)
DWDDynam      |   54     54  53.1s
[633](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:636)
Test Summary: | Pass  Total   Time
[634](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:637)
CPGDynam      |   71     71  22.2s
[635](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:638)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[636](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:639)
│ Consider using tuples instead.
[637](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:640)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[638](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:641)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[639](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:642)
│ Consider using tuples instead.
[640](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:643)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[641](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:644)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[642](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:645)
│ Consider using tuples instead.
[643](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:646)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[644](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:647)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[645](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:648)
│ Consider using tuples instead.
[646](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:649)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32

In the current PR #123 we get some warnings that should be run down. It looks like we are passing parameters as an array instead of a tuple somewhere. This is a good first issue and a potentially breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant