Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Basis" for rewrite rules #37

Merged
merged 1 commit into from
Aug 21, 2024
Merged

"Basis" for rewrite rules #37

merged 1 commit into from
Aug 21, 2024

Conversation

kris-brown
Copy link
Collaborator

This PR implements using an optional extra piece of data, $B \rightarrow L$, which controls the timing of rewrites by restricting the notion of 'match' to be for a subobject of $L$.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (a9697dc) to head (f2375bc).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Upstream.jl 70.00% 3 Missing ⚠️
src/Visualization.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   78.30%   83.01%   +4.71%     
==========================================
  Files           7        7              
  Lines         295      318      +23     
==========================================
+ Hits          231      264      +33     
+ Misses         64       54      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown merged commit 896a599 into main Aug 21, 2024
9 checks passed
@kris-brown kris-brown deleted the subtimer branch August 22, 2024 03:49
@kris-brown kris-brown self-assigned this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant