Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quotes to regex for terraform outputs #996

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

davidsmejia
Copy link
Contributor

@davidsmejia davidsmejia commented Nov 22, 2024

Issue Number

N/A

Purpose/Implementation Notes

Deploys look like they are failing but they are fine. This issue is caused by upgrading to terraform 0.14.0 where
output strings are wrapped in quotes. This PR updates our regex to account for them.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes

Screenshots

N/A

Copy link
Member

@nozomione nozomione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidsmejia davidsmejia merged commit beb19d5 into dev Nov 22, 2024
5 checks passed
@davidsmejia davidsmejia deleted the davidsmejia/fix-outputs-quotes branch November 22, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants