Revert terraform resources aws version 3.37.0 implementation #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g changes from feature/batch to be in accordance with old 3.37.0 implementation.
avrohomgottlieb
changed the title
davidsmejia
reviewed
Nov 22, 2024
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
davidsmejia
approved these changes
Nov 22, 2024
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
avrohomgottlieb
deleted the
avrohom/revert-tf-resources-aws-version-3-37-0-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#964
Purpose/Implementation Notes
We are attempting to revert the aws_provider version to what it was before we began making changes, which was 3.37.0. This PR updates the resources to be compatible again with 3.37.0 (and comments out the newer implementation).
The next step would be to incrementally update aws_provider version to where we need it to be, which is 5.12.0, but gradually updating the resources as we update the versions.
Types of changes
What types of changes does your code introduce?
Functional tests
N/A
Checklist
Screenshots
N/A