Production Deploy #433
Merged
Production Deploy #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidsmejia
commented
Sep 14, 2023
•
davidsmejia
commented
- Updates to client
- upgrade to nextjs13 / yarn3 / storybook 7
- removes call to contribute banner
* remove warning 'Received 'true' for a non-boolean attribute crossOrigin' at compile time * remove the flag deprecation warning '--static-dir CLI flag is deprecated’ at compile time * remove the error 'TypeError: Cannot read property 'definitions' of undefined’ at compile * remove the performance warning ‘Reverting webpack devtool to 'eval-source-map'. Changing the webpack devtool in development mode will cause severe performance regressions’ at compile by removing the custom devtool override in next.config since it reverts back to eval-source-map during the compilation (ref: https://nextjs.org/docs/messages/improper-devtool) * upgrade node image to v18.17.1 (stored the node image to the enviromental variable) * upgrade the storybook to v7 from v6 * (fix) resolve runtime error 'MyDocument.getInitialProps() should resolve to an object with a html' * (fix) add the legacyBehavior prop to Next.js buit-in Link component * (fix) remove the warning 'The value at .experimental has an unexpected property, productionBrowserSourceMaps, which is not in the list of allowed propertie'(no longer the property of experiment) at compile * (fix) resolve 'Warning: A title element received an array with more than 1 element as children' at compile by updating the PageTitle component JSX * (fix) resolve the datatype warning ‘Failed prop type: Invalid prop supplied to , expected one of type [string]’ at compile * upgrade Yarn to latest stable v3.6.3 from v1.22.19 and add a local .gitignore file in the client directory for Yarn none-zero-installs instead of editing .gitignore in the root * (edit) specified Yarn version in the docker compose * (fix) remove ‘RESOURCE-NAME’ undefined errors at the runtime (storybook): - add the alias for the data directory for import - adjust the data and remove unused resource files - update the stories based on the above changes * remove trailing white space and add new line at the end in .gitignore * remove trailing whitespace after the yarn set version command * (test) remove trailing whitespace inauto-generate file ./yarn/release * (edit) exclude .yarn (auto-generated files) from pre-commit test and revert back the test change (previous commit for removing the whitespace from auti-generated ./yarn/release) file * (edit) use module import, add addons, and rearrange the properties in alphabetical order * (edit) remove the env var for the docker node image and hard-code in the docker compose file
* (edit) unrender the contribution banner from UI (so that we can toggle back the banner as required in the future) * create the ContributePageCard and render in the contribute page * (edit) remove the download guideline as PDF button and delete the PFD file in /src/public * (edit) update the URL for contribute_hsform and delete the contribute_pdf (for previously deleted PDF file) property * (edit) rename ContributePageCard to WarningCard and define props and add the dropshadow * (edit) add the WarningCard to the contirbute page instead of Layout
nozomione
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.