429 - Upgrade to Nextjs 13 / Yarn 3 / Storybook #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in' at compile time
…ated’ at compile time
…defined’ at compile
…urce-map'. Changing the webpack devtool in development mode will cause severe performance regressions’ at compile by removing the custom devtool override in next.config since it reverts back to eval-source-map during the compilation (ref: https://nextjs.org/docs/messages/improper-devtool)
…lve to an object with a html'
…d property, productionBrowserSourceMaps, which is not in the list of allowed propertie'(no longer the property of experiment) at compile
…han 1 element as children' at compile by updating the PageTitle component JSX
…pplied to , expected one of type [string]’ at compile
…itignore file in the client directory for Yarn none-zero-installs instead of editing .gitignore in the root
…ok): - add the alias for the data directory for import - adjust the data and remove unused resource files - update the stories based on the above changes
…revert back the test change (previous commit for removing the whitespace from auti-generated ./yarn/release) file
… alphabetical order
1 task
davidsmejia
approved these changes
Sep 13, 2023
docker-compose.env
Outdated
| @@ -11,6 +11,7 @@ DOCS_PORT=8001 | |||
| # Client | |||
| STORYBOOK_PORT=7001 | |||
| CLIENT_PORT=7000 | |||
| NODE_IMAGE=node:18.17.1 | |||
There was a problem hiding this comment.
I don't think this is necessary. I could kinda see an argument for it if we used it in multiple places but I would expect to find the version of the container I am running in docker-compose.yml. If it is all the same could we keep it in that file?
There was a problem hiding this comment.
Got it, let's remove it then!
…the docker compose file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closing #429
Purpose/Implementation Notes
The following changes were made in this PR:
v14.17tov18.17.1v6tov7v11tov13v1tov3in project./yarnauto-generated directory from the pre-commit workflow (otherwise test will fail due to the trailing whitespace e3d361f)Types of changes
Checklist