Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix - dispatch_to_batch is null bug #1019

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

avrohomgottlieb
Copy link
Contributor

Issue Number

N/A

Purpose/Implementation Notes

The correct null check for a foreign key is via isnull, instead of is_null. This PR makes fixes this error in dispatch_to_batch.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

N/A

Checklist

N/A

Screenshots

N/A

Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a test to cover this as well.

@avrohomgottlieb avrohomgottlieb merged commit 1d8036e into dev Dec 9, 2024
5 checks passed
@avrohomgottlieb avrohomgottlieb deleted the avrohom/hot-fix-dispatch-to-batch branch December 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants