1014 - Optimizing the Sync Command #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #1014
Purpose/Implementation Notes
This PR optimizes our usage of the
aws s3 synccommand, which had previously been a bottleneck with some projects during computed file generation. With projects that have many files, requesting a large subset of those files via the--includeoption causes the execution to slow and appear to hang, while it iteratively searches the entire file space for each individual file mentioned within an--includestatement. Our solution was to make searches more granular by chopping up the file space, resulting in significantly quicker searches.Types of changes
What types of changes does your code introduce?
Functional tests
N/A
Checklist
Screenshots
N/A