-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rOpenScPCA to renv/docker in ewing module #881
Add rOpenScPCA to renv/docker in ewing module #881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -49,7 +49,7 @@ jobs: | |||
- name: Build image | |||
uses: docker/build-push-action@v6 | |||
with: | |||
context: "{{defaultContext}}:analyses/simulate-sce" | |||
context: "{{defaultContext}}:analyses/cell-type-ewings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a good typo to fix!
Actually @allyhawkins how did you add |
I did use |
Makes sense, I don't think you need to add anything here. I have a lot of confidence it will be used soon! |
@@ -40,7 +40,7 @@ jobs: | |||
test-build: | |||
name: Test Build Docker Image | |||
if: github.event_name == 'pull_request' || (contains(github.event_name, 'workflow_') && !inputs.push-ecr) | |||
runs-on: ubuntu-latest | |||
runs-on: openscpca-22.04-big-disk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain to me why we need this? It will be challenging to manage this under our current paradigm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I was getting an error running out of disk space when trying to build the image (see https://github.com/AlexsLemonade/OpenScPCA-analysis/actions/runs/11844604285).
I can see if I can make the image smaller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or skip the test build for this module... but that seems not great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a change for now, but if we could make this smaller, that'd be swell. I prefer how we were handling permissions.
Purpose/implementation Section
Please link to the GitHub issue that this pull request addresses.
Towards #878
What is the goal of this pull request?
Here I'm just adding
rOpenScPCA
to the lock file forrenv
and subsequently the Docker image. I also noticed a typo in the GHA for building the ewing's docker image that I fixed.Briefly describe the general approach you took to achieve this goal.
Installed the package and then took a snapshot.
If known, do you anticipate filing additional pull requests to complete this analysis module?
Yes!
Next up, I'll be updating the cluster template to use the functions in
rOpenScPCA.
I also plan on incorporating Leiden clustering results to the plots now that we have that functionality inrOpenScPCA
.Author checklists
Analysis module and review
README.md
has been updated to reflect code changes in this pull request.Reproducibility checklist
Dockerfile
.environment.yml
file.renv.lock
file.