Test fix for docker actions failing after miniforge #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jashapiro - the analysis module is what is failing? |
The analysis module failed because it is still pulling the old Docker image, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the changes made in #740, I think the most likely culprit for the failures in #743 is that I had removed adding conda.sh to
/etc/profile.d. It seems possible (likely) that GHA isn't activating.bashrcwhen running its jobs, but hope it is the fix. I am just including the cell-type-ewings module for now. If this works after testing, I will add the same changes to all docker files and instructions.