revert cell-type-ewings conda-lock #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Confirmed that the only difference between this conda-lock.yml and the previous version before #714 is the defaults removal 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #714 for the
cell-type-ewingsmodule resulted in a docker image that was too big to build and push on our current GHA setup (see #717).In the interests of not having a docker image that doesn't match the
conda-lockfile, I am reverting the conda-lock changes in that module. I retained one change, which was to remove thedefaultschannel from theconda-lock.ymlfile manually. No packages were using this channel due to its low priority, so removing it from the list did require altering any installed packages. This change should allow future updates to proceed without errors (unless the channel list changes again).