Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using precommit action locally #819

Closed
jashapiro opened this issue Oct 16, 2024 · 2 comments
Closed

Switch to using precommit action locally #819

jashapiro opened this issue Oct 16, 2024 · 2 comments
Assignees

Comments

@jashapiro
Copy link
Member

It seems like our repo is now too large for pre-commit.ci, as we are hitting the 30s timeout for cloning the repo on that service. As we expect it to only get larger as more analysis results are included, I fear that this is a problem that is not going to get any better unless there are changes I would not expect from a free service (related discussion: pre-commit-ci/issues#183)

Since we are not using the autofix feature here, I expect we should be just fine with the GitHub Action, so I will make an action to use that.

          > @jashapiro can you have a look at what's up with this pre-commit action (I don't have permissions)?This PR is otherwise approved.

We seem to be timing out on cloning the repo. This could be a more significant problem than just this PR: There is a time limit of 30s for cloning and we seem to be taking ~25 seconds in other PRs, meaning we are probably quite close to the repo size limit for the service.

Originally posted by @jashapiro in #813 (comment)

@jashapiro
Copy link
Member Author

After #820 goes in, I need to remove pre-commit.ci from this repo and update the required checks for merging.

@jashapiro
Copy link
Member Author

Done and branch rules updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant