-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Updates eslint-config-prettier to v8 - abandoned #342
base: master
Are you sure you want to change the base?
Conversation
Hey! Changelogs info seems to be missing or might be in incorrect format. |
Thanks for the PR! This section of the codebase is owner by https://github.com/AlexRogalskiy/ - if they write a comment saying "LGTM" then it will be merged. |
Thanks for opening an issue! Make sure you've followed CONTRIBUTING.md. |
Hello from PR HelperIs your PR ready for review and processing? Mark the PR ready by including If you still have work to do, even after marking this ready. Put the PR on hold by including |
bd97df9
to
0ebc206
Compare
0ebc206
to
2a6ef1b
Compare
2a6ef1b
to
ceed7a9
Compare
ceed7a9
to
d27dc79
Compare
This pull request has merge conflicts that must be resolved before it can be merged. @renovate[bot] please rebase it. https://rook.io/docs/rook/master/development-flow.html#updating-your-fork |
d27dc79
to
f0136a3
Compare
f0136a3
to
a7717d0
Compare
Signed-off-by: Renovate Bot <[email protected]>
a7717d0
to
dc0a093
Compare
Pull request by bot. No need to analyze |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
^6.15.0
->^8.0.0
Release Notes
prettier/eslint-config-prettier
v8.7.0
Compare Source
v8.6.0
Compare Source
v8.5.0
Compare Source
v8.4.0
Compare Source
v8.3.0
Compare Source
v8.2.0
Compare Source
v8.1.0
Compare Source
v8.0.0
Compare Source
Changed: All configs have been merged into one!
To upgrade, change:
Into:
The
"prettier"
config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@thorn0) for pointing this out!
If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:
(The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main
"prettier"
config does not include the rules from it.)Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).
v7.2.0
Compare Source
v7.1.0
Compare Source
v7.0.0
Compare Source
Changed: At least ESLint 7.0.0 is now required.
Changed: [arrow-body-style] and [prefer-arrow-callback] are no longer turned off by default. They only need to be turned off if you use [eslint-plugin-prettier]. If you do, add
"prettier/prettier"
to your"extends"
array to turn them off again.Alternatively, update [eslint-plugin-prettier] to version 3.2.0 or later which automatically turns off these two rules in its
"plugin:prettier/recommended"
config.The CLI helper tool only warns about these rules if you have the
"prettier/prettier"
rule enabled for a file.Changed:
no-tabs
is now a validatable rule. If you use it, you should enableallowIndentationTabs
so that the rule works regardless of your Prettier config:Changed: The CLI helper tool is now called just
eslint-config-prettier
instead ofeslint-config-prettier-check
. This is so thatnpx eslint-config-prettier
always works regardless of whether you have already installedeslint-config-prettier
or not: If you have, the local installation is used; if you haven’t,npx
downloads a temporary copy.Changed: The CLI helper tool no longer requires you to pipe the output of
eslint --print-config
to it. Instead, it does that automatically for you via ESLint API:s added in ESLint v7.Before:
After:
Improved: The npm package is now 75% smaller.
Configuration
📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Europe/Moscow, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.