Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Most recent curl-sys crate update causes SnarkOS build to fail due to SnarkOS MSRV being at v1.76.0 #3403

Open
iamalwaysuncomfortable opened this issue Sep 23, 2024 · 2 comments
Labels
bug Incorrect or unexpected behavior

Comments

@iamalwaysuncomfortable
Copy link
Contributor

iamalwaysuncomfortable commented Sep 23, 2024

🐛 Bug Report

The curl-sys library version was recently bumped to 0.4.76 which updated the Rust MSRV in that crate to 1.80.0. This currently causes SnarkOS to fail to build using cargo build or cargo install to fail.

This is resolved if the MSRV in SnarkOS is updated.

Steps to Reproduce

  1. Navigate to the SnarkOS main directory
  2. Execute cargo build or cargo install --path .
  3. The build fails with the error:
error: unsupported output in build script of `curl-sys v0.4.76+curl-8.10.1`: `cargo::rustc-check-cfg=cfg(libcurl_vendored,link_libnghttp2,link_libz,link_openssl,)`
Found a `cargo::key=value` build directive which is reserved for future use.
Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.

Potential Fixes

  • Update the MSRV in SnarkOS/SnarkVM to Rust v1.80.0 or forcing usage of Rust >1.80.0 fixes the issue. As of this bug report, the full consequences of updating the Rust MSRV in SnarkOS haven't been weighed, but it likely should be updated as more libraries may start to fail in the future.
@zosorock
Copy link
Contributor

@iamalwaysuncomfortable could you please confirm this is fixed with the merging of #3413?

@raychu86
Copy link
Contributor

Should be resolved with #3413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behavior
Projects
None yet
Development

No branches or pull requests

3 participants