-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve visual integration / use VSCode color palette #3
Comments
Thanks for openning this issue @dnwerner! I agree that this would improve the experience of using the extension, and I see a couple of routes that we could take in order to accomplish that. However, it would also require quite a bit of work to get everything looking good, so I'm not sure if/when I will be able to work on this |
ℹ️ In 3cde4eb it can be seen how to override JSROOT's default styles |
The issue became a bit more important recently: The new tab bar, although a welcome re-addition, suffers from poor contrast in a few of the default color dark schemes when using the extension in "light mode" - it seems like the background of the tabs either uses an incorrect palette-color or the font color is chosen incorrectly. Contrast is much better in the extension's dark mode and seems to work as intended there - but the dark mode makes the content very dark, which might not always be preferable. It might be helpful to have separate dark-modes for content and UI? |
There seem to be a few additional issues:
|
Thanks for all the comments @dnwerner! I've addressed some of the issues you mentioned in 0a7dc41, which will be included in a release soon. For the overflow behaviour (point 3 in comment) I'm CC'ing @linev, as maybe this should be handled in JSROOT's side. On a related note: the extension would definitely benefit of a full revamp of the UI to match more closely the editor's styles, but I don't think I have the capacity to work on that. If someone is interested in the project, any help is welcome! 🙂 |
This is need some work - now JSROOT do not uses jquery-ui and needs to implement such features itself. |
Visual Studio Code uses a wide range of different visual styles. It would be a great visual improvement if the extension could reflect the default editor background color, or try to match the editor's color palette in its header bar.
The text was updated successfully, but these errors were encountered: