Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visual integration / use VSCode color palette #3

Open
dnwerner opened this issue Mar 25, 2021 · 6 comments
Open

Improve visual integration / use VSCode color palette #3

dnwerner opened this issue Mar 25, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dnwerner
Copy link

Visual Studio Code uses a wide range of different visual styles. It would be a great visual improvement if the extension could reflect the default editor background color, or try to match the editor's color palette in its header bar.

@AlbertoPdRF
Copy link
Owner

Thanks for openning this issue @dnwerner!

I agree that this would improve the experience of using the extension, and I see a couple of routes that we could take in order to accomplish that. However, it would also require quite a bit of work to get everything looking good, so I'm not sure if/when I will be able to work on this

@AlbertoPdRF AlbertoPdRF added the enhancement New feature or request label Apr 1, 2021
@AlbertoPdRF
Copy link
Owner

ℹ️ In 3cde4eb it can be seen how to override JSROOT's default styles

@dnwerner
Copy link
Author

dnwerner commented Aug 29, 2022

The issue became a bit more important recently: The new tab bar, although a welcome re-addition, suffers from poor contrast in a few of the default color dark schemes when using the extension in "light mode" - it seems like the background of the tabs either uses an incorrect palette-color or the font color is chosen incorrectly.

image

Contrast is much better in the extension's dark mode and seems to work as intended there - but the dark mode makes the content very dark, which might not always be preferable. It might be helpful to have separate dark-modes for content and UI?

@dnwerner
Copy link
Author

There seem to be a few additional issues:

  1. There seems to be no highlight color for the currently selected tab
  2. (minor) there probably shouldn't be a black bar at the bottom of the currently active tab, since in "tab-layout-logic" it's part of the same content
  3. The old tab bar's high-capacity/overflow behavior drew the tab titles in multiple lines - could this be re-introduced as optional behavior in the future?

AlbertoPdRF added a commit that referenced this issue Jul 5, 2023
This is part of #3.
@AlbertoPdRF
Copy link
Owner

Thanks for all the comments @dnwerner! I've addressed some of the issues you mentioned in 0a7dc41, which will be included in a release soon. For the overflow behaviour (point 3 in comment) I'm CC'ing @linev, as maybe this should be handled in JSROOT's side.

On a related note: the extension would definitely benefit of a full revamp of the UI to match more closely the editor's styles, but I don't think I have the capacity to work on that. If someone is interested in the project, any help is welcome! 🙂

@AlbertoPdRF AlbertoPdRF added the help wanted Extra attention is needed label Jul 5, 2023
@linev
Copy link
Contributor

linev commented Jul 5, 2023

The old tab bar's high-capacity/overflow behavior drew the tab titles in multiple lines - could this be re-introduced as
optional behavior in the future?

This is need some work - now JSROOT do not uses jquery-ui and needs to implement such features itself.
I cannot promise to implement it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants