Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-pane: Theming support #49

Closed
braven112 opened this issue Nov 7, 2023 · 1 comment · Fixed by #50
Closed

auro-pane: Theming support #49

braven112 opened this issue Nov 7, 2023 · 1 comment · Fixed by #50
Assignees
@fajar-apri-alaska @irma-kurnia-alaska
Labels
auro-pane not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Nov 7, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231
And this auro-hyperlink pr AlaskaAirlines/auro-hyperlink#185

Exit criteria

All tokens referencing --auro have been updated.
@braven112 braven112 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members auro-pane labels Nov 7, 2023
@braven112 braven112 changed the title auro-pane: [feature summary] auro-pane: Theming support Nov 7, 2023
@irma-kurnia-alaska
Copy link
Contributor

Hi @fajar-apri-alaska or @braven112,

Could you please to assign me this issue to helping? Thank you..

irma-kurnia-alaska added a commit to irma-kurnia-alaska/auro-pane that referenced this issue Nov 9, 2023
@irma-kurnia-alaska
perf(token): update token per new theming AlaskaAirlines#49
5c4f1ed 
Change to be committed:
modified: package-lock.json
modified: package.json
modified: demo/index.html
modified: src/style.scss
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue Nov 9, 2023
Merged
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request Nov 9, 2023 that will close this issue
Update CSS token per new design system theming capability #50
Merged
3 tasks
jason-capsule42 pushed a commit that referenced this issue Nov 16, 2023
@irma-kurnia-alaska @jason-capsule42
perf(token): update token per new theming #49
e3e4a1a 
Change to be committed:
modified: package-lock.json
modified: package.json
modified: demo/index.html
modified: src/style.scss
jason-capsule42 pushed a commit that referenced this issue Nov 16, 2023
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
7bafabe 
## [2.0.1](v2.0.0...v2.0.1) (2023-11-16)

### Bug Fixes

* feedback review for update library dependency and remove unused code ([3dd12da](3dd12da))

### Performance Improvements

* **token:** update token per new theming [#49](#49) ([e3e4a1a](e3e4a1a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-pane not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CSS token per new design system theming capability irma-kurnia-alaska/auro-pane
5 participants
@blackfalcon @braven112 @fajar-apri-alaska @irma-kurnia-alaska @Patrick-Daly-AA