Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-menu: ssr support #226

Closed
rmenner opened this issue Nov 5, 2024 · 0 comments · Fixed by #227
Closed

auro-menu: ssr support #226

rmenner opened this issue Nov 5, 2024 · 0 comments · Fixed by #227
Assignees
@rmenner
Labels
auro-menu

Comments

@rmenner
Copy link
Contributor

rmenner commented Nov 5, 2024 •
edited
Loading

General Support Request

Error rendering component mark.es6 window is not defined

Possible Solution

Remove dependency on mark.js

Additional context

No response

Exit criteria

No response
@rmenner rmenner self-assigned this Nov 5, 2024
rmenner added a commit that referenced this issue Nov 5, 2024
@rmenner
perf: replace mark package with simple regex and replace #226
ca17029
@rmenner rmenner linked a pull request Nov 5, 2024 that will close this issue
perf: replace mark package with simple regex and replace #226 #227
Merged
6 tasks
rmenner added a commit that referenced this issue Nov 5, 2024
@rmenner
perf: add logic for including nesting spacer spans #226
7a6d4bd
rmenner added a commit that referenced this issue Nov 5, 2024
@rmenner
perf: revert match work api example #226
588106a
jason-capsule42 pushed a commit that referenced this issue Nov 5, 2024
@rmenner @jason-capsule42
perf: replace mark package with simple regex and replace #226
f5c039e
jason-capsule42 pushed a commit that referenced this issue Nov 5, 2024
@rmenner @jason-capsule42
perf: add logic for including nesting spacer spans #226
3451b3c
jason-capsule42 pushed a commit that referenced this issue Nov 5, 2024
@rmenner @jason-capsule42
perf: revert match work api example #226
f0f7bd8
blackfalcon pushed a commit that referenced this issue Nov 5, 2024
@semantic-release-bot
chore(release): 4.1.4 [skip ci]
152c6bd 
## [4.1.4](v4.1.3...v4.1.4) (2024-11-05)

### Performance Improvements

* add logic for including nesting spacer spans [#226](#226) ([3451b3c](3451b3c))
* replace mark package with simple regex and replace [#226](#226) ([f5c039e](f5c039e))
* revert match work api example [#226](#226) ([f0f7bd8](f0f7bd8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmenner rmenner

Labels
auro-menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: replace mark package with simple regex and replace #226 AlaskaAirlines/auro-menu
2 participants
@rmenner @Patrick-Daly-AA