Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-flight: Theming Support #97

Closed
braven112 opened this issue Oct 20, 2023 · 2 comments · Fixed by #98
Closed

auro-flight: Theming Support #97

braven112 opened this issue Oct 20, 2023 · 2 comments · Fixed by #98
Assignees
@jordanjones243 @fajar-apri-alaska @irma-kurnia-alaska
Labels
auro-flight Type: Feature New Feature
Milestone
Auro-Flight NextRC

Comments

@braven112
Copy link
Member

braven112 commented Oct 20, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231
and this auro-hyperlink pr AlaskaAirlines/auro-hyperlink#185

Exit criteria

All tokens referencing --auro have been updated.
Validate the changes after this work item is also complete
@braven112 braven112 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members auro-flight labels Oct 20, 2023
@braven112 braven112 changed the title auro-flight: [feature summary] auro-flight: Theming Support Oct 20, 2023
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Oct 20, 2023
fajar-apri-alaska added a commit that referenced this issue Oct 20, 2023
@fajar-apri-alaska
perf(token): update token per new theming #97
553c03b 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-flight-header.scss
	modified:   src/style-flight-main.scss
	modified:   src/style-flight.scss
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Oct 20, 2023
Merged
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request Oct 25, 2023 that will close this issue
Update CSS token per new design system theming capability #98
Merged
3 tasks
fajar-apri-alaska added a commit that referenced this issue Oct 31, 2023
@fajar-apri-alaska
perf(token): update token per new theming #97
74f648d 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-flight-header.scss
	modified:   src/style-flight-main.scss
	modified:   src/style-flight.scss
@blackfalcon
Copy link
Member

Once the following PR is shipped, this issue will be UNBLOCKED

@blackfalcon blackfalcon added this to the Auro-Flight NextRC milestone Nov 8, 2023
@blackfalcon
Copy link
Member

Once this issue is unblocked, the PR needs to be repointed to a new RC branch versus main

fajar-apri-alaska added a commit that referenced this issue Nov 9, 2023
@fajar-apri-alaska
perf(token): update token per new theming #97
0210c29 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-flight-header.scss
	modified:   src/style-flight-main.scss
	modified:   src/style-flight.scss
@jordanjones243 jordanjones243 self-assigned this Dec 1, 2023
jason-capsule42 pushed a commit that referenced this issue Dec 5, 2023
@fajar-apri-alaska @jason-capsule42
perf(token): update token per new theming #97
4db8ddf 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-flight-header.scss
	modified:   src/style-flight-main.scss
	modified:   src/style-flight.scss
blackfalcon pushed a commit that referenced this issue Dec 5, 2023
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
d7eabbe 
# [2.5.0](v2.4.1...v2.5.0) (2023-12-05)

### Features

* update node support to include version 20 ([e7ae9c3](e7ae9c3))

### Performance Improvements

* **token:** update token per new theming [#97](#97) ([4db8ddf](4db8ddf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

@fajar-apri-alaska fajar-apri-alaska

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-flight Type: Feature New Feature
Projects
None yet
Milestone
Auro-Flight NextRC
Development

Successfully merging a pull request may close this issue.

Update CSS token per new design system theming capability AlaskaAirlines/auro-flight
6 participants
@blackfalcon @braven112 @jordanjones243 @fajar-apri-alaska @irma-kurnia-alaska @Patrick-Daly-AA