Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Sammy 5차 PR 리뷰 반영 및 리팩토링 #39

Open
2 tasks
astraum opened this issue Jun 9, 2022 · 0 comments
Open
2 tasks

[refactor] Sammy 5차 PR 리뷰 반영 및 리팩토링 #39

astraum opened this issue Jun 9, 2022 · 0 comments
Assignees
@mybloom @astraum
Labels
BE 💊 Refactor Refactoring codes
Milestone
5차 리뷰 반영(codesqua...

Comments

@astraum
Copy link
Collaborator

astraum commented Jun 9, 2022

💡 Issue

5차 PR에서 받은 피드백을 기반으로 리팩토링 수행

💻 작업 내용

  • 작업 1
  • 작업 2
@astraum astraum added 💊 Refactor Refactoring codes BE labels Jun 9, 2022
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: List<Reservation>을 일급 컬렉션으로 래핑 (#39)
5930685
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: Invoice 생성 위치 이동 (#39)
4227aac
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: ParametrizedTest 적용 (#39)
5e92d55
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: ParametrizedTest 적용 (#39)
edae122
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: 문자열을 AccommodationType으로 전달하여 동등성 검사 (#39)
ca345f6
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: accommodationImages를 일급 클래스로 래핑 (#39)
c81195f
astraum added a commit that referenced this issue Jun 9, 2022
@astraum
refactor: 위도, 경도값 반환을 Accommodation에 위임 (#39)
bbb5f07
@mybloom mybloom changed the title [refactor] 5차 PR 리뷰 반영 및 리팩토링 [refactor] Sammy 5차 PR 리뷰 반영 및 리팩토링 Jun 10, 2022
astraum added a commit that referenced this issue Jun 10, 2022
@astraum
refactor: askForImages 메서드 복구 (#39)
0639d1c
astraum added a commit that referenced this issue Jun 10, 2022
@astraum
refactor: List<Accommodation>을 일급 컬렉션으로 래핑 (#39)
d6ac368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mybloom mybloom

@astraum astraum

Labels
BE 💊 Refactor Refactoring codes
Projects
None yet
Milestone
5차 리뷰 반영(codesquad-members-2022/airbn...
Development

No branches or pull requests
2 participants
@mybloom @astraum